[core] Implement redirection without tee and rotation on windows #49906
+178
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/windows-redirection
branch
from
4000f16 to
db56818
Compare
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
jjyao
reviewed
Jan 17, 2025
|
Offline discussion with @jjyao , this PR will focus on windows stream redirection, and I will followup with other two PRs to
|
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/windows-redirection
branch
from
3d4e757 to
80220aa
Compare
jjyao
reviewed
Jan 18, 2025
|
|
||
| std::ostringstream buffer; | ||
| buffer << file.rdbuf(); | ||
| RAY_CHECK(file.good()) << "Fails to read from file " << fname; |
There was a problem hiding this comment.
After reading, the file should be in the eof state which is not good()?
There was a problem hiding this comment.
I don't think so.
I did a simply experiment.
Setup:
[~]
ubuntu@hjiang-devbox-pg$ echo "helloworld" > hello.out
[~]
ubuntu@hjiang-devbox-pg$ g++ -std=c++17 fstream_test.cc -o test
[~]
ubuntu@hjiang-devbox-pg$ ./test
0
helloworld
Code
#include <fstream>
#include <sstream>
#include <cassert>
#include <iostream>
int main() {
std::fstream fs("/home/ubuntu/hello.out");
std::ostringstream buffer;
buffer << fs.rdbuf();
std::cout << fs.rdstate() << std::endl;
std::cout << std::move(buffer).str() << std::endl;
assert(fs.good());
return 0;
}
jjyao
reviewed
Jan 18, 2025
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/windows-redirection
branch
from
4a19181 to
960b54e
Compare
|
Triggered windows tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows #49821 (which only implement linux part), this PR follows up for part of the windows implementation.